Fix S110 Security Issue in Extractor

Replace try-except-pass block in src/helia/analysis/extractor.py with specific exception handling and logging.

Problem Statement

The Security Sentinel identified a distinct security risk (S110) in src/helia/analysis/extractor.py. A try-except-pass block silently suppresses errors, making debugging impossible and potentially hiding security-critical failures or data corruption issues.

Findings

File: src/helia/analysis/extractor.py
Issue: S110 - try-except-pass detected.
Impact: Critical for visibility and system stability. Silent failures can lead to unpredictable application states.

Proposed Solutions

Option 1: Log and Re-raise

Approach: Catch the specific exception, log the error with a traceback, and optionally re-raise it if the application cannot recover.

Pros:

Full visibility into errors.
Prevents silent failures.

Cons:

May require error handling changes upstream if exceptions are raised.

Option 2: Log and Continue (Safe Fallback)

Approach: Catch specific exception, log it as an error/warning, and set a safe default value or continue processing if appropriate.

Pros:

Prevents application crash while maintaining visibility.

Cons:

Might mask severity if logs aren't monitored.

Recommended Action

To be filled during triage.

Technical Details

Affected files:

src/helia/analysis/extractor.py

Resources

Source: Security Sentinel Report

Acceptance Criteria

try-except-pass block removed.
Specific exception type caught (not bare except:).
Error logged using logging module (not print).
Unit tests added to verify exception handling behavior.

Work Log

2025-12-20 - Initial Creation

By: Claude Code

Actions:

Created todo based on Security Sentinel findings.

2.0 KiB Raw Blame History