63 lines
1.3 KiB
Markdown
63 lines
1.3 KiB
Markdown
---
|
|
status: pending
|
|
priority: p2
|
|
issue_id: "003"
|
|
tags: ["ops", "quality", "python"]
|
|
dependencies: []
|
|
---
|
|
|
|
# Switch to Logging in Main
|
|
|
|
Replace `print` statements with the standard `logging` module in `src/helia/main.py`.
|
|
|
|
## Problem Statement
|
|
|
|
`src/helia/main.py` uses `print` statements for output. This prevents proper log level management, timestamping, and integration with monitoring systems.
|
|
|
|
## Findings
|
|
|
|
- **File:** `src/helia/main.py`
|
|
- **Issue:** Use of `print` for logging information.
|
|
- **Impact:** Ops/Visibility reduced.
|
|
|
|
## Proposed Solutions
|
|
|
|
### Option 1: Standard Logging
|
|
|
|
**Approach:** Import `logging`, configure a basic logger, and replace `print()` calls with `logger.info()`, `logger.error()`, etc.
|
|
|
|
**Pros:**
|
|
- Standard practice.
|
|
- Configurable output levels and formats.
|
|
|
|
**Cons:**
|
|
- Slight initial setup overhead.
|
|
|
|
## Recommended Action
|
|
|
|
**To be filled during triage.**
|
|
|
|
## Technical Details
|
|
|
|
**Affected files:**
|
|
- `src/helia/main.py`
|
|
|
|
## Resources
|
|
|
|
- **Source:** Kieran Python Reviewer
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [ ] `logging` module imported and configured.
|
|
- [ ] All diagnostic `print` statements replaced with `logger` calls.
|
|
- [ ] Import organization fixed in `src/helia/main.py` (mentioned in findings).
|
|
|
|
## Work Log
|
|
|
|
### 2025-12-20 - Initial Creation
|
|
|
|
**By:** Claude Code
|
|
|
|
**Actions:**
|
|
- Created todo based on code review findings.
|